Skip to content

Conversation

@waliwali777
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Others

Description

auto_parallel_sync_shared_params pass 添加开关,可以在脚本进行开关控制
开 pass: --pipeline_parallel_config "auto_parallel_sync_shared_params"
关 pass: --pipeline_parallel_config ""

@paddle-bot
Copy link

paddle-bot bot commented Mar 10, 2025

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 49.93%. Comparing base (098f234) to head (f818e91).
Report is 296 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/auto_training_args.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10057      +/-   ##
===========================================
- Coverage    50.21%   49.93%   -0.28%     
===========================================
  Files          757      757              
  Lines       122399   122591     +192     
===========================================
- Hits         61464    61221     -243     
- Misses       60935    61370     +435     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@waliwali777 waliwali777 force-pushed the add_sync_param_pass_flag branch from 34a3ca3 to f818e91 Compare March 17, 2025 09:47
Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 4afa702 into PaddlePaddle:develop Mar 18, 2025
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants