Skip to content

Conversation

@Function-Samuel
Copy link
Contributor

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Others

Description

@paddle-bot
Copy link

paddle-bot bot commented Mar 14, 2025

Thanks for your contribution!

Copy link
Contributor

@liym27 liym27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 44144a5 into PaddlePaddle:develop Mar 17, 2025
8 of 11 checks passed
@codecov
Copy link

codecov bot commented Mar 17, 2025

Codecov Report

Attention: Patch coverage is 14.89362% with 40 lines in your changes missing coverage. Please review.

Project coverage is 49.93%. Comparing base (42ba2c0) to head (b4df468).
Report is 254 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/llama/modeling_network.py 14.89% 40 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10137      +/-   ##
===========================================
- Coverage    49.95%   49.93%   -0.02%     
===========================================
  Files          757      757              
  Lines       122540   122587      +47     
===========================================
+ Hits         61217    61218       +1     
- Misses       61323    61369      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants