Skip to content

Conversation

@DrownFish19
Copy link
Collaborator

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Function optimization

PR changes

APIs

Description

Compatible with the padding_side in _pad

@paddle-bot
Copy link

paddle-bot bot commented Apr 16, 2025

Thanks for your contribution!

@codecov
Copy link

codecov bot commented Apr 16, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 49.01%. Comparing base (9f5b697) to head (52204df).
Report is 192 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/tokenizer_utils_base.py 25.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10423      +/-   ##
===========================================
- Coverage    49.01%   49.01%   -0.01%     
===========================================
  Files          765      765              
  Lines       125877   125884       +7     
===========================================
+ Hits         61699    61700       +1     
- Misses       64178    64184       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ZHUI ZHUI merged commit 0074e7e into PaddlePaddle:develop Apr 18, 2025
8 of 12 checks passed
@DrownFish19 DrownFish19 deleted the dev_20250416_fix_padding_side branch April 18, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants