Skip to content

Conversation

@ftgreat
Copy link

@ftgreat ftgreat commented Dec 25, 2024

PR types

New features

PR changes

Models

Description

Add Aquila2 model

Signed-off-by: ftgreat <ftgreat@163.com>
@paddle-bot
Copy link

paddle-bot bot commented Dec 25, 2024

Thanks for your contribution!

Copy link
Collaborator

@DrownFish19 DrownFish19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Dec 25, 2024

Codecov Report

Attention: Patch coverage is 15.87697% with 1012 lines in your changes missing coverage. Please review.

Project coverage is 52.38%. Comparing base (801682d) to head (4bfeb7b).
Report is 511 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/transformers/aquila2/modeling.py 13.81% 786 Missing ⚠️
paddlenlp/transformers/aquila2/tokenizer.py 22.85% 108 Missing ⚠️
paddlenlp/transformers/aquila2/fusion_ops.py 17.43% 90 Missing ⚠️
paddlenlp/transformers/aquila2/configuration.py 28.20% 28 Missing ⚠️

❌ Your patch check has failed because the patch coverage (15.87%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (52.38%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9692      +/-   ##
===========================================
+ Coverage    52.34%   52.38%   +0.04%     
===========================================
  Files          726      723       -3     
  Lines       117265   113500    -3765     
===========================================
- Hits         61377    59461    -1916     
+ Misses       55888    54039    -1849     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@@ -0,0 +1,29 @@
# Copyright (c) 2024 PaddlePaddle Authors. All Rights Reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上传个小模型,写一下 model,Tokenizer的测试吧。模型加载,前向运行。Tokenizer加载,文本转id

@DrownFish19
Copy link
Collaborator

在PaddleNLP/tests下辛苦增加一下单元测试,可参考https://github.com/PaddlePaddle/PaddleNLP/tree/develop/tests/transformers/qwen2 实现,重点验证模型初始化和运行能力。

@github-actions
Copy link

github-actions bot commented Mar 1, 2025

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions github-actions bot added stale and removed stale labels Mar 1, 2025
@ZHUI
Copy link
Contributor

ZHUI commented Mar 18, 2025

你好,这个PR还更新吗?

@github-actions
Copy link

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions github-actions bot added stale and removed stale labels May 18, 2025
@github-actions
Copy link

This Pull Request is stale because it has been open for 60 days with no activity. 当前Pull Request 60天内无活动,被标记为stale。

@github-actions github-actions bot added the stale label Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants