feat(settings): add desktop server port controls#9
Open
pascalandr wants to merge 1 commit intofix/tauri-configured-portsfrom
Open
feat(settings): add desktop server port controls#9pascalandr wants to merge 1 commit intofix/tauri-configured-portsfrom
pascalandr wants to merge 1 commit intofix/tauri-configured-portsfrom
Conversation
Let users persist fixed HTTP and HTTPS launcher ports from the remote access settings, with validation and restart confirmation, while keeping blank values mapped to automatic port selection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
PR NeuralNomadsAI#335 makes the packaged desktop launchers honor persisted
httpPort/httpsPortvalues, but there is still no UI for users to set or clear those values.This follow-up adds that missing settings surface without changing the existing launcher precedence or startup behavior.
What Changed
packages/ui/src/components/settings/remote-access-settings-section.tsxHTTPS portandHTTP portinputspackages/ui/src/stores/preferences.tsxhttpPort/httpsPortsupport in the server settings storepackages/server/src/config/schema.tshttpPort/httpsPortconfig fieldspackages/server/src/settings/service.tspackages/server/src/settings/migrate.tspreferences.httpPort/preferences.httpsPortinto the server-owned config bucketpackages/ui/src/lib/i18n/messages/*/remoteAccess.tsNotes
Validation
npm run build --workspace @codenomad/uinpm run typecheck --workspace @neuralnomads/codenomad-electron-appnpm run typecheck --workspace @neuralnomads/codenomadcurrently hits existing branch-baseline issues unrelated to this follow-up