Skip to content

feat(settings): add desktop server port controls#9

Open
pascalandr wants to merge 1 commit intofix/tauri-configured-portsfrom
feat/desktop-port-settings-ui
Open

feat(settings): add desktop server port controls#9
pascalandr wants to merge 1 commit intofix/tauri-configured-portsfrom
feat/desktop-port-settings-ui

Conversation

@pascalandr
Copy link
Copy Markdown

Summary

  • add HTTP and HTTPS port inputs to the Remote Access settings
  • persist fixed desktop launcher ports through the server config, while keeping blank values mapped to automatic port selection
  • validate port values locally and require a restart confirmation before applying changes

Why

PR NeuralNomadsAI#335 makes the packaged desktop launchers honor persisted httpPort / httpsPort values, but there is still no UI for users to set or clear those values.

This follow-up adds that missing settings surface without changing the existing launcher precedence or startup behavior.

What Changed

  • packages/ui/src/components/settings/remote-access-settings-section.tsx
    • added HTTPS port and HTTP port inputs
    • blank values keep automatic port selection
    • invalid values are rejected locally
    • applying changes prompts for restart
  • packages/ui/src/stores/preferences.tsx
    • added first-class httpPort / httpsPort support in the server settings store
  • packages/server/src/config/schema.ts
    • added validated optional httpPort / httpsPort config fields
  • packages/server/src/settings/service.ts
    • normalizes and sanitizes persisted port values
  • packages/server/src/settings/migrate.ts
    • migrates legacy preferences.httpPort / preferences.httpsPort into the server-owned config bucket
  • packages/ui/src/lib/i18n/messages/*/remoteAccess.ts
    • added the new remote access strings across all supported locales

Notes

  • If another process is already using a configured port, startup will fail until the port is changed or freed.
  • This PR is intentionally limited to the settings UI and persisted config path; it does not add fallback/retry behavior.

Validation

  • npm run build --workspace @codenomad/ui
  • npm run typecheck --workspace @neuralnomads/codenomad-electron-app
  • npm run typecheck --workspace @neuralnomads/codenomad currently hits existing branch-baseline issues unrelated to this follow-up

Let users persist fixed HTTP and HTTPS launcher ports from the remote access settings, with validation and restart confirmation, while keeping blank values mapped to automatic port selection.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant