Some additional notes around webhook signature verification. #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckCrawford
force-pushed
the
fb/webhook-signature-notes
branch
from
90d72d8 to
f131fe5
Compare
tpgaviria
approved these changes
Feb 16, 2024
Contributor
tpgaviria
left a comment
tpgaviria
left a comment
There was a problem hiding this comment.
just a small comment but it could just be a style choice 😉
docs/webhooks/04-Signatures.md
Outdated
| <!-- theme: warning --> | ||
| > PagerDuty webhook payloads support unicode characters. If your implementation is converting the request body | ||
| > from string to bytes [or vice-versa]; ensure that you are using the proper UTF-8 character encoding. |
Contributor
There was a problem hiding this comment.
nit: comma instead of semicolon here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before Merging!