Skip to content

Conversation

@warpech
Copy link
Contributor

@warpech warpech commented Jun 12, 2019

This PR makes some cleanup in packages and fixes few failing benchmarks. The reason I made this PR, though, is to surpass GitHub security alerts regarding an outdated vulnerable version of lodash.

warpech added 3 commits June 12, 2019 11:33
replace outdated test package Jasmine, stored in test/lib/, with current version installed through NPM

tested the following commands successfully:
npm run test
test/SpecRunner.html
test/SpecRunnerMin.html
grunt bump
grunt uglify
@warpech warpech requested a review from tomalec June 12, 2019 09:41
Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomalec tomalec merged commit 8b11f79 into master Jun 12, 2019
@tomalec tomalec deleted the upgrade-packages branch June 12, 2019 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants