Merged
Conversation
that caused some benchmark specs to fail
replace outdated test packages Jasmine and Benchmark, stored in test/lib/, with current versions installed through NPM this solves the problems reported by GitHub Security audit tested the following commands successfully: npm run test npm run test-sync npm run test-async test/SpecRunner.html (includung "Run Benchmark" two buttons) grunt bump
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some cleanup in packages and fixes few failing benchmarks. The reason I made this PR, though, is to surpass GitHub security alerts regarding an outdated vulnerable version of
lodash.