configurator: treat empty CRIC DDM blacklist as valid instead of error #588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbarreir
reviewed
Oct 10, 2025
| except Exception as e: | ||
| # Only on actual failure do we fall back to empty and continue | ||
| self.log_stream.warning( | ||
| "Failed to retrieve ddmblacklist(read); defaulting to empty. Error: %s", e |
Contributor
There was a problem hiding this comment.
f-string please.
Otherwise by eye it looks OK, but should be tested for ATLAS CRIC once to see it doesn't break anything
Member
Author
There was a problem hiding this comment.
Yes of course, changed it to f-string - thanks!
Contributor
There was a problem hiding this comment.
The fact that the non-f-string is there, makes me think you didn't install the pre-commit tools (flynt), which should have fixed it automatically
Member
Author
There was a problem hiding this comment.
Yes I don't have it installed for my forked repo on my laptop.. will fix this asap
tmaeno
approved these changes
Oct 10, 2025
…ensures that write, read, and full (DDM detailed) blacklist retrievals behave consistently and only fail on actual fetch/parse errors (None or exceptions), as per Valerio’s feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid flagging empty JSON responses from CRIC as retrieval errors. Empty dumps ({} → []) are now considered valid and result in empty blacklist lists, while only actual retrieval or parsing failures trigger warnings and fallback behavior.