data carousel: fix review feedback in data_carousel_module.py#670
Merged
mightqxc merged 2 commits intodata_carouselfrom Mar 2, 2026
Merged
data carousel: fix review feedback in data_carousel_module.py#670mightqxc merged 2 commits intodata_carouselfrom
mightqxc merged 2 commits intodata_carouselfrom
Conversation
Co-authored-by: mightqxc <19180940+mightqxc@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Modularize Data Carousel DB methods in DBProxy
data carousel: fix review feedback in data_carousel_module.py
Mar 2, 2026
mightqxc
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses five code-quality issues found during review of the
DataCarouselModuleextraction frommisc_standalone_module.Fixes
resubmit_data_carousel_request_JEDI):(f"already {dc_req_spec.status} ; skipped")had no effect — changed totmp_log.debug(...).get_data_carousel_request_id_JEDI): Addedself._commit()on both return paths to prevent idle-in-transaction connections with Postgres autocommit disabled.get_data_carousel_staging_requests_JEDI):"no queued request"/"got N queued requests"→"no staging request"/"got N staging requests"to match the actualstatus=stagingquery.get_data_carousel_requests_by_task_status_JEDI):"no queued request"→"no request"since this method filters by arbitrary task status, not specificallyqueued.resubmit_data_carousel_request_JEDI): Removedto_resubmit = Falsewhich was assigned but never read.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.