Use regexp for gpu_spec model matching, supporting both positive and exclusion patterns

[EdwardKaravakis]

Summary

• Extends PR Add != operator support for GPU model exclusion in brokerage #676 to support wildcards in the gpu_spec model != exclusion pattern
• Uses fnmatch so both exact names and glob patterns work (e.g., !=Tesla P100-SXM2-16GB or !=*P100*)

Change

# Before
if "model" in architecture_map["gpu"] and excluded_model in architecture_map["gpu"]["model"]:
    continue

# After
if "model" in architecture_map["gpu"] and any(fnmatch.fnmatch(m, excluded_model) for m in architecture_map["gpu"]["model"]):
    continue

[EdwardKaravakis]

One more review @tmaeno to implement Johannes's wildcard use as in "!=P100"

[tmaeno]

How about allowing regexp to specify the model? You wouldn't need separate code paths
for matching and excluding patterns. For "!=P100”, it would be "^(?!.P100).$”.

[EdwardKaravakis]

Much cleaner with your suggestion, working on it - thank you!

[EdwardKaravakis]

@tmaeno please have a look at this new implementation based on your suggestion

[tmaeno]

Actually, I started thinking we need to introduce a separate entry in the gpu_spec for exclusion. The current code does not exclude the PQ when an item in the list passes the antimatch pattern. One possibility would be to add "excl": True, and then the logic could be something like

is_match = any(re.match(host_gpu_spec["model"], m) for m in architecture_map["gpu"]["model"])
if is_match == host_gpu_spec.get("excl", False):
    continue

{"model": "^.*P100.*", "excl": true} will exclude PQs with P100, while {"model": "^(?!.*P100).*$"} will include PQs if some model names don't contain P100.

[EdwardKaravakis]

Thank you Tadashi, I will have a look tomorrow morning. On Mar 12, 2026 18:23, Tadashi Maeno ***@***.***> wrote: @tmaeno commented on this pull request. Actually, I started thinking we need to introduce a separate entry in the gpu_spec for exclusion. The current code does not exclude the PQ when an item in the list passes the antimatch pattern. One possibility would be to add "excl": True, and then the logic could be something like is_match = any(re.match(host_gpu_spec["model"], m) for m in architecture_map["gpu"]["model"]) if is_match == host_gpu_spec.get("excl", False): continue {"model": "^.*P100.*", "excl": true} will exclude PQs with P100, while {"model": "^(?!.*P100).*$"} will include PQs if some model names don't contain P100. — Reply to this email directly, view it on GitHub<#677 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACI3SY2ZUKOAHZOAYOHUVE34QLXABAVCNFSM6AAAAACWPWHN52VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTSMZYGM4TSNBXGQ>. You are receiving this because you authored the thread.Message ID: ***@***.***>