MatchMaker: search for strings that equal rather than contain factorName#6
Merged
MatchMaker: search for strings that equal rather than contain factorName#6
Conversation
meredjj
approved these changes
Nov 1, 2021
Contributor
meredjj
left a comment
meredjj
left a comment
There was a problem hiding this comment.
I don't see any issue with this. It shouldn't cause any problems. Good catch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not positive if we want this, but this might avoid an issue I came across - I was specifying "bmi_baseline_1 " as a desired factor and was getting "unit_bmi_baseline_1" returned instead from columns that contained entries like
bmi_baseline_1,age_at_bmi_baseline_1, andunit_bmi_baseline_1