Skip to content

Conversation

@wjiayis
Copy link

@wjiayis wjiayis commented Jan 25, 2026

  1. fix: remove definition of currentConversation as it is not used (to fix the following error when running npm run build:prd:chrome
> webapp@0.0.0 build:prd:chrome
> bash -c 'source ./scripts/build-prd-chrome.sh'

🧩 Start building Chrome Extension ...
📦 Version: 2.16.0
📦 Monorepo Revision: 9fc435
📦 Beta Build: false
📦 API Endpoint: https://app.paperdebugger.com

❌ Failed to build Chrome Extension, please check logs/build.log

> webapp@0.0.0 build
> tsc -b && npm run _build:default && npm run _build:background && npm run _build:intermediate && npm run _build:settings && npm run _build:popup

src/views/settings/setting-text-input.tsx(32,13): error TS6133: 'currentConversation' is declared but its value is never read.
  1. fix: change matching from substring to exact, to prevent gpt-4.1-mini from matching to gpt-4.0 (edit: typo, should be gpt-4.1), making the method more robust to the order of supported models defined.

  2. [edit] refactor: use IsCustom and not redefine logic in NewAIClientV2

@wjiayis wjiayis mentioned this pull request Jan 25, 2026
@wjiayis wjiayis changed the title Fix stale modelslug fix: Fix stale modelslug Jan 25, 2026
@wjiayis wjiayis changed the title fix: Fix stale modelslug fix: stale modelslug Jan 25, 2026
@wjiayis wjiayis mentioned this pull request Jan 25, 2026
@wjiayis wjiayis force-pushed the fix-stale-modelslug branch from 836aa7e to bb5137c Compare January 25, 2026 09:23
Copy link
Member

@4ndrelim 4ndrelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wjiayis
Copy link
Author

wjiayis commented Jan 25, 2026

@4ndrelim All remaining relevant changes from #97 have been ported over to this PR. I'll proceed to close #97. Feel free to merge this PR into PaperDebugger:fix-stale-modelslug if all's good!

@wjiayis wjiayis changed the title fix: stale modelslug fix: stale modelSlug Jan 25, 2026
@wjiayis wjiayis requested a review from 4ndrelim January 25, 2026 14:11
@4ndrelim
Copy link
Member

lgtm thanks!

@4ndrelim 4ndrelim merged commit 5176de9 into PaperDebugger:fix-stale-modelslug Jan 25, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants