Do not set gamerule during conversion when it was not set prior#29
Merged
Conversation
Member
|
The original problem is actually whether the field was set. You should adjust all of the convert functions so that they avoid writing any value unless the original field is present. |
Contributor
Author
|
I can make that adjustment. 👍 I would agree |
chickeneer
force-pushed
the
convertInt-v4658
branch
from
2c4f7f5 to
e82416a
Compare
chickeneer
changed the title
Spottedleaf
changed the title
Spottedleaf
pushed a commit
to PaperMC/Paper
that referenced
this pull request
Dec 31, 2025
See PaperMC/DataConverter#29 Note that this is just a sync from DataConverter, as we do not make use of the LEVEL data type for converting (we use DFU).
b0ykoe
pushed a commit
to InfernalSuite/AdvancedSlimePaper
that referenced
this pull request
Dec 31, 2025
…113a3bbff9 Do not set gamerules when they are not set before conversion See PaperMC/DataConverter#29 Note that this is just a sync from DataConverter, as we do not make use of the LEVEL data type for converting (we use DFU).
Y2Kwastaken
pushed a commit
to Y2Kwastaken/Paper
that referenced
this pull request
Feb 4, 2026
See PaperMC/DataConverter#29 Note that this is just a sync from DataConverter, as we do not make use of the LEVEL data type for converting (we use DFU).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
V4658.java- There is a (correct) data converter for the experimental gamerule max_minecart_speed. Since it is only experimental, most servers do not even have this value set yet.DataConverter/src/main/java/ca/spottedleaf/dataconverter/minecraft/versions/V4658.java
Line 118 in c0a465e
The problem is that the
convertIntmethod sets an empty string as the valueDataConverter/src/main/java/ca/spottedleaf/dataconverter/minecraft/versions/V4658.java
Line 48 in c0a465e
Causing the following server error log when loading a world that does not have this gamerule set in its world files.
[22:09:35 WARN]: Not a number missed input: {"minecraft:max_minecart_speed":""}Inspecting the level.dat prior to running it through a 1.21.11 server shows that this gamerule was never set. So the dataconversion introduced the erroneous error when the server loads the world's gamerules.