Added GlobalRegionScheduler#getExecutor and RegionScheduler#getExecutor#32
Closed
jdkeke142 wants to merge 2 commits into
Closed
Added GlobalRegionScheduler#getExecutor and RegionScheduler#getExecutor#32jdkeke142 wants to merge 2 commits into
jdkeke142 wants to merge 2 commits into
Conversation
Member
|
I think the method names should just be getExecutor(). They are on interfaces with the names Region and Global, it doesn't need to be repeated in the method name. |
jdkeke142
changed the title
kashike
reviewed
Apr 3, 2023
Member
There was a problem hiding this comment.
Sorry, to clarify, you'll have to edit the commit summary for the patch files to retain shorter names - you can shove the longer description into the commit description.
Author
There was a problem hiding this comment.
Sorry it's me not being familiar with the patch system. Does it look better now?
Added GlobalRegionScheduler#getExecutor and RegionScheduler#getExecutor to get respectively an executor of the global region and to get an executor of a corresponding region at a location
Added GlobalRegionScheduler#getExecutor and RegionScheduler#getExecutor to get respectively an executor of the global region and to get an executor of a corresponding region at a location
Member
|
I don't want to encourage usage of CompletableFuture, since they do not follow reasonable error handling. I've learned this the hard way from Mojang's code, and I don't expect plugins to do a better job. |
killerprojecte
pushed a commit
to killerprojecte/Folia
that referenced
this pull request
Jun 17, 2023
Update Upstream (Folia)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added GlobalRegionScheduler#getExecutor and RegionScheduler#getExecutor to get respectively an executor of the global region and to get an executor of a corresponding region at a location. I find that these methods were useful in regular paper when working with CompletableFuture, I think other developers too. This PR aims to reintroduce them