Don't create help and permissions files by default

Adding permissions to commands that don't have any yet may be eventually put into a more easily usable config option, or into a separate plugin. Changing help messages seems to have no use whatsoever and offers less than stellar configurability anyway

Author: kennytv

paper-server/src/main/java/org/bukkit/craftbukkit/CraftServer.java

@@ -1111,19 +1111,18 @@ private void loadIcon() {
         }
     }
 
-    @SuppressWarnings({ "unchecked", "finally" })
     private void loadCustomPermissions() {
         File file = new File(this.configuration.getString("settings.permissions-file"));
+        if (!file.isFile()) {
+            return;
+        }
+
         FileInputStream stream;
 
         try {
             stream = new FileInputStream(file);
         } catch (FileNotFoundException ex) {
-            try {
-                file.createNewFile();
-            } finally {
-                return;
-            }
+            return;
         }
 
         Map<String, Map<String, Object>> perms;

paper-server/src/main/java/org/bukkit/craftbukkit/help/HelpYamlReader.java

@@ -1,12 +1,10 @@
 package org.bukkit.craftbukkit.help;
 
 import java.io.File;
-import java.io.IOException;
 import java.io.InputStreamReader;
 import java.nio.charset.StandardCharsets;
 import java.util.LinkedList;
 import java.util.List;
-import java.util.logging.Level;
 import org.bukkit.ChatColor;
 import org.bukkit.Server;
 import org.bukkit.configuration.ConfigurationSection;
@@ -27,21 +25,18 @@ public HelpYamlReader(Server server) {
 
         File helpYamlFile = new File("help.yml");
         YamlConfiguration defaultConfig = YamlConfiguration.loadConfiguration(new InputStreamReader(this.getClass().getClassLoader().getResourceAsStream("configurations/help.yml"), StandardCharsets.UTF_8));
+        this.helpYaml = defaultConfig;
 
-        try {
-            this.helpYaml = YamlConfiguration.loadConfiguration(helpYamlFile);
-            this.helpYaml.options().copyDefaults(true);
-            this.helpYaml.setDefaults(defaultConfig);
-            this.helpYaml.options().setHeader(defaultConfig.options().getHeader());
-
+        if (helpYamlFile.isFile()) {
             try {
-                this.helpYaml.save(helpYamlFile);
-            } catch (IOException ex) {
-                server.getLogger().log(Level.SEVERE, "Could not save " + helpYamlFile, ex);
+                this.helpYaml = YamlConfiguration.loadConfiguration(helpYamlFile);
+                this.helpYaml.options().copyDefaults(true);
+                this.helpYaml.setDefaults(defaultConfig);
+                this.helpYaml.options().setHeader(defaultConfig.options().getHeader());
+            } catch (Exception ex) {
+                server.getLogger().severe("Failed to load help.yml. Verify the yaml indentation is correct. Reverting to default help.yml.");
+                this.helpYaml = defaultConfig;
             }
-        } catch (Exception ex) {
-            server.getLogger().severe("Failed to load help.yml. Verify the yaml indentation is correct. Reverting to default help.yml.");
-            this.helpYaml = defaultConfig;
         }
     }