Opening the container in adventure mode will fire PlayerInteractEvent twice simultaneously

[KioProject123]

Expected behavior

PlayerInteractEvent will only be fired once

Observed/Actual behavior

PlayerInteractEvent will be fired twice simultaneously

Use the following plugins for testing

    @EventHandler(priority = EventPriority.MONITOR)
    public void onPlayerInteract(PlayerInteractEvent e) {
        e.getPlayer().sendMessage(e.getHand() + " " + Bukkit.getCurrentTick());
    }

In survival mode

In adventure mode

Steps/models to reproduce

Right click container in adventure mode

Plugin and Datapack List

Only plugins for testing

Paper version

This server is running Paper version git-Paper-333 (MC: 1.20.4) (Implementing API version 1.20.4-R0.1-SNAPSHOT) (Git: 0b95298)
You are running the latest version

Other

No response

[Machine-Maker]

My instinct says this isn't a simple fix. The 2 events are different, they have different actions and they are triggered by 2 different packets, the use item and hand swing packet. I think if we remove one of them, some other adventure mode scenario isn't covered, but I can't remember or figure out through testing what that scenario is.

EDIT: aha, I figured it out. Ok, so when a player in adventure left clicks a block they can't interact with, like a dirt block, it only sends a hand swing packet which we use to trigger the interact event with the LEFT_CLICK_BLOCK action. But there isn't a good way at the moment to distinguish between the swing packets that first followed the interact packet (which triggers the first interact event)

This situation was chosen as the least bad.

[blubbarbs]

Hi, please don't change this behavior. It actually has some uses, for example as a method to check if a block is "interactable" in that right clicking it will perform some sort of action. This is being used in kernitus' OldCombatMechanics plugin as of this issue and this behavior has been present for multiple years. Fixing this may break backwards compatibility for plugins besides OldCombatMechanics so please keep this behavior.

[Owen1212055]

See above. In general, there is no way to handle this interaction event nicely. Naturally, Minecraft has changed their interaction packet logic ages ago, so this event has to do a lot of "guestimating" which causes a lot of problems.

And if plugins DO use this behavior, not sure if this is even worth fixing?
So with this given info, closing as wont fix.