Unable to add metadata to blocks with no visible errors

[VinceSMC]

Expected behavior

To add metadata to blocks.

Observed/Actual behavior

As of 1.20.5+, this does no longer work - No visible errors.

Steps/models to reproduce

By adding metadata to blocks.

Plugin and Datapack List

[19:06:13 INFO]: Server Plugins (26):
[19:06:13 INFO]: Paper Plugins:
[19:06:13 INFO]: - AdvancedKits
[19:06:13 INFO]: Bukkit Plugins:
[19:06:13 INFO]: - AuraSkills, Citizens, DecentHolograms, FastAsyncWorldEdit, ItemEdit, LuckPerms, Multiverse-Core, PlaceholderAPI, SuperiorSkyblock2, SupremeChat
[19:06:13 INFO]: SupremeCollections, SupremeCore, SupremeCrafting, SupremeCurrency, SupremeEnchantments, SupremeEssentials, SupremeLevels, SupremeMenus, SupremeMinions, SupremeTelepads
[19:06:13 INFO]: SupremeTrades, SupremeTriggers, TAB, Vault, WorldGuard

[19:05:06 INFO]: There are 3 data pack(s) enabled: [vanilla (built-in)], [file/bukkit (world)], [paper (built-in)]
[19:05:06 INFO]: There are no more data packs available

Paper version

[19:04:52 INFO]: Checking version, please wait...
[19:04:52 INFO]: This server is running Paper version 1.20.6-115-master@9d6f2cc (2024-05-28T14:55:16Z) (Implementing API version 1.20.6-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.20.6-112-347bbe3 (MC: 1.20.6)

Other

No response

[lynxplay]

Please provide simple reproduction code here.
Are you talking about https://jd.papermc.io/paper/1.20.6/org/bukkit/metadata/Metadatable.html ?

[VinceSMC]

Please provide simple reproduction code here. Are you talking about https://jd.papermc.io/paper/1.20.6/org/bukkit/metadata/Metadatable.html ?

Thanks for the quick reply. Yes, I'm talking about https://jd.papermc.io/paper/1.20.6/org/bukkit/metadata/Metadatable.html

You can simply reproduce it to apply a metadata to any block and check whether it has been added.

The issue lies with 1.20.5+, it worked fine on 1.20.4 and lower.

[lynxplay]

I am having trouble replicating this.
The following example code

@EventHandler
public void on(final PlayerDropItemEvent event) {
    final Block targetBlockExact = event.getPlayer().getTargetBlockExact(10);
    if (targetBlockExact == null) return;

    targetBlockExact.setMetadata("testplugin:testdata", new FixedMetadataValue(this, "hi"));
    targetBlockExact.getMetadata("testplugin:testdata").stream()
        .map(m -> m.getOwningPlugin().getName() + " -> " + m.asString())
        .forEach(event.getPlayer()::sendRawMessage);
}

prints me "Paper-Test-Plugin -> hi" when dropping an item while looking (in this case) sand.

Do you have any minimal reproduction steps here?

[VinceSMC]

Turns out that the issue was not with adding metadata to blocks. The problem was when adding an item to the inventory that has item flags, it removed some of the item’s flags.

[lynxplay]

I don't know the specifics of that, but item flags are generally completely changed, see our update post.
Might be worth getting more info on our discord, I'll close this specific issue then.