-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
ItemMeta unhandled tags are not handled for data upgrades #10979
Copy link
Copy link
Closed
Labels
status: acceptedDisputed bug is accepted as valid or Feature accepted as desired to be added.Disputed bug is accepted as valid or Feature accepted as desired to be added.type: bugSomething doesn't work as it was intended to.Something doesn't work as it was intended to.upstream: bukkitIssues exists in Bukkit and/or CraftBukkit.Issues exists in Bukkit and/or CraftBukkit.upstream: spigotIssues exists in Spigot.Issues exists in Spigot.
Metadata
Metadata
Assignees
Labels
status: acceptedDisputed bug is accepted as valid or Feature accepted as desired to be added.Disputed bug is accepted as valid or Feature accepted as desired to be added.type: bugSomething doesn't work as it was intended to.Something doesn't work as it was intended to.upstream: bukkitIssues exists in Bukkit and/or CraftBukkit.Issues exists in Bukkit and/or CraftBukkit.upstream: spigotIssues exists in Spigot.Issues exists in Spigot.
Type
Fields
Give feedbackNo fields configured for Bug.
Projects
Status
Done
Primary discussion goes back to here;
https://discord.com/channels/289587909051416579/555462289851940864/1254135843182870659
ItemMeta's history of upgrading data is more of a "we manually pick out the data and so we can save it back in any format desired", this is a tragic solution but has mostly survived with manual bodges to the data here and there, the issue comes in is, what happens to the data we don't know how to handle?
The data is not stored in a manner that it's picked apart and can be reassembled, the only real solution here would be to see if we can run this data through DFU/DC in some manner, #10609 is going to be the best final solution here, but;
if viable, run existing unhandled data through DFU
Merging the agreed-upon solution as discussed in the linked PR is generally going to be the best solution here in the long run, as it preserves the entire data set exactly as it does elsewhere so that we can upgrade it. I semi-want to deprecate storing ItemStacks inside of Bukkits configuration system, the system is fragile and as much as I've warned over the years, there is generally no persistently glowing warning that "hey, this is a bad idea if you care about the longevity of your data"