-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Sweeping Edge knockback vanilla inconsistency #11025
Copy link
Copy link
Labels
priority: lowThis issue only describes a minor inconvenience.This issue only describes a minor inconvenience.status: acceptedDisputed bug is accepted as valid or Feature accepted as desired to be added.Disputed bug is accepted as valid or Feature accepted as desired to be added.type: bugSomething doesn't work as it was intended to.Something doesn't work as it was intended to.
Description
Metadata
Metadata
Assignees
Labels
priority: lowThis issue only describes a minor inconvenience.This issue only describes a minor inconvenience.status: acceptedDisputed bug is accepted as valid or Feature accepted as desired to be added.Disputed bug is accepted as valid or Feature accepted as desired to be added.type: bugSomething doesn't work as it was intended to.Something doesn't work as it was intended to.
Type
Fields
Give feedbackNo fields configured for Bug.
Projects
Status
Done
A recent spigot commit no longer applies knockback if Entity#hurt returned false.
This however is incorrect as vanilla would apply the knockback even if hurt returned false.
Another victim of spigots abuse of the boolean return value to indicate damage event cancel.
Cannot be solved nicely right now without heavy work on #hurt. Needs revisiting after softspoon.