Player#sendEquipmentChange produces invalid packet with empty map (causes disconnect)

[NonSwag]

Expected behavior

Method call should silently fail

Observed/Actual behavior

ClientboundSetEquipmentPacket is sent anyway

Steps/models to reproduce

invoke Player#sendEquipmentChange with an empty map as slots argument

Plugin and Datapack List

irrelevant

Paper version

[21:30:36 INFO]: Checking version, please wait...
[21:30:36 INFO]: This server is running Paper version 1.21.4-121-main@88bbead (2025-01-22T20:05:15Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are running the latest version
Previous version: 1.21.4-118-73f7736 (MC: 1.21.4)

Other

ClientboundSetEquipmentPacket does not allow for empty slots

io.netty.handler.codec.DecoderException: Failed to decode packet 'clientbound/minecraft:set_equipment'

Caused by: java.lang.IndexOutOfBoundsException: readerIndex(2) + length(1) exceeds writerIndex(2): PooledUnsafeDirectByteBuf(ridx: 2, widx: 2, cap: 2)

[electronicboy]

We throw on every other illegal arg, not sure if we wouldn't here?

[NonSwag]

Good question. I'd argue that NMS also just drops the packet if the slots are empty, but either way, I'm fine with an exception.