PlayerInteractEvent RIGHT_CLICK_BLOCK fired when interacting with entities

Expected behavior

right clicking an entity with blocks behind them shouldn't fire playerinteractevent for the block

Observed/Actual behavior

It fires playerinteractevent for the block behind the entity

Steps/models to reproduce

right click a mob with blocks behind them

Plugin and Datapack List

N/A

Paper version

This server is running Paper version 1.21.4-DEV-main@88bbead (1970-01-01T00:00:00Z) (Implementing API version 1.21.4-R0.1-SNAPSHOT)
You are 1 version(s) behind
Download the new version at: https://papermc.io/downloads/paper
Previous version: 1.21.4-121-88bbead (MC: 1.21.4)

Other

No response

[Machine-Maker]

You are gonna have to be more specific about your replication steps. This for example, doesn't fire the PlayerInteractEvent at all. What mob, what blocks, how far, etc?

You are gonna have to be more specific about your replication steps. This for example, doesn't fire the PlayerInteractEvent at all. What mob, what blocks, how far, etc?

hold a bone in your hand and right click a cow

[Machine-Maker]

Ok, I can replicate that. It's fired by the call in ServerGamePacketListener#handleUseItem

[notTamion]

The only way this seems to be fixable is by checking for entities in the players line of sight as there doesn't seem to be a reliable way to distinguish an actual UseItemPacket from one that is falsely sent by the client in this case

The only way this seems to be fixable is by checking for entities in the players line of sight as there doesn't seem to be a reliable way to distinguish an actual UseItemPacket from one that is falsely sent by the client in this case

I am fine with this solution, I mean line of sight checks are already used in player interact event for arm swing packets IIRC

[ImMarvolo]

hi, will the bug be fixed?

[electronicboy]

Probably not as there is no clean way to mitigate this which doesn't also break existing usage of the interact event, plugins would need to mitigate this calling for cases they don't care about where viable