Add BlockDropItemEvent::addDrop(ItemStack)

[ens-gijs]

Is your feature request related to a problem?

There is no way for a plugin to directly create an instance of an Item

Describe the solution you'd like.

Add BlockDropItemEvent::addDrop(ItemStack)

Describe alternatives you've considered.

I could use World drop item, but this is rather annoying and breaks the event handling chain of BlockDropItemEvent as any downstream handlers will encounter an empty drops list (or not find the Item I wish to add) and will have to also hook an item spawn event and have no idea that spawn was caused by a block having "dropped" it.

Other

No response

[electronicboy]

Event objects can't have side-effects, they're just plain simple POJOs. The items list is mutable, but, I know that I personally found myself having to patch stuff to remove items that were removed from that event from the world manually as custom stuff is ofc not handled there;

There is probably some room for improvement here

[BlueNightFury46]

Definitely not an ideal method, but if you really want to add an ItemStack you could try something like this:

  if(event.getItems().size()>0){
       ItemStack stack = new ItemStack(Material.DIAMOND, 2);
      
       Item temporaryItem = event.getItems().get(0);
       
       temporaryItem.setItemStack(stack);
       event.getItems().add(temporaryItem);
       }

[Warriorrrr]

I don't think such a new method is necessary, you can use dropItem and add the item to the list of drops to let the server take care of removing the item for you if the event is cancelled.

This can break though, if a plugin removes the drops of another plugin that were added this way then they'll stay in the world, despite what the javadoc for getItems promises in terms of removal. I think this part could be improved by using a custom list that removes item entities currently in the world when they are removed/cleared from the list.