PreCreatureSpawnEvent getSpawnLocation() clones every time

Spark Profile

https://spark.lucko.me/xttFcIZuCd

Description of issue

This event is quite hot so calling .clone() in every listener has a measurable performance impact, it'd be nice if we get a method that returns the spawn location directly without clone()

Plugin and Datapack List

N/A

Server config files

N/A

Paper version

Paper 1.21.4 BUILD 222

Other

No response

[emilyy-dev]

The spark report is unavailable/expired, please reupload it. 10 microseconds is not going to slow down the tick rate of the server (0.02% of an acceptable MSPT!), the location is cloned is so plugins can't just modify it, affecting other plugins' readings, but without the actual spark report there is little to go off of.

The spark report is unavailable/expired, please reupload it. 10 microseconds is not going to slow down the tick rate of the server (0.02% of an acceptable MSPT!), the location is cloned is so plugins can't just modify it, affecting other plugins' readings, but without the actual spark report there is little to go off of.

Is there a more efficient way to prevent mob spawns in certain areas? I am aiming for zero cost plugins, i.e don't show up on spark report, I have mostly been successful except for this where seems to be no possible workaround

[emilyy-dev]

Again, would need to see a real spark report, plus corresponding code, to have a sense with what we're dealing with here in terms of configuration, environment, hardware etc. Having attempted to reproduce this issue myself, even after configuring high spawn rates, heaps of things showed up on the spark report without location cloning being one of them (and the way that the way profiling works means that there is always a chance, even if miniscule, that your plugin shows up in a report even if it doesn't do anything intensive). Exposing the uncloned location is not something we want to do, and without information on how to make this reproducible, spending development time in problems that don't exist is not something we aim for.