Skip to content

Don't show entities from hideEntity API when changing dimension - #13350

Merged
Warriorrrr merged 1 commit into
PaperMC:mainfrom
Doc94:feature/hide-show-entity-match-with-player-behaviour
Jul 28, 2026
Merged

Don't show entities from hideEntity API when changing dimension#13350
Warriorrrr merged 1 commit into
PaperMC:mainfrom
Doc94:feature/hide-show-entity-match-with-player-behaviour

Conversation

@Doc94

@Doc94 Doc94 commented Nov 27, 2025

Copy link
Copy Markdown
Member

This PR aims to fix an issue where if the Entity hidden change dimension its removed from the hidden list causing can be see again. this was based in another patches where (like scheulders) this check is made.

Close #12599
Close #13335

@Doc94
Doc94 requested a review from a team as a code owner November 27, 2025 13:01
@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue Nov 27, 2025
@Doc94
Doc94 force-pushed the feature/hide-show-entity-match-with-player-behaviour branch from b48ad16 to e3af65c Compare July 13, 2026 01:29

@Warriorrrr Warriorrrr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like there's any way for an entity to be removed with this reason and not be added back, so lgtm

@papermc-projects papermc-projects Bot moved this from Awaiting review to Delayed approval in Paper PR Queue Jul 26, 2026
@papermc-projects papermc-projects Bot moved this from Delayed approval to Full approval in Paper PR Queue Jul 27, 2026
@Warriorrrr Warriorrrr changed the title not remove the entity from hide API if change dimension Don't show entities from hideEntity API when changing dimension Jul 28, 2026
@Warriorrrr
Warriorrrr merged commit 782a076 into PaperMC:main Jul 28, 2026
5 checks passed
@github-project-automation github-project-automation Bot moved this from Full approval to Merged in Paper PR Queue Jul 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

Make player and entity vanish api behave the same Teleporting hidden by default entity across worlds resets which players can see it

3 participants