CraftMagicNumbers.loadAdvancement saves advancements to an incorrect folder

[ShaneBeee]

Expected behavior

When loading a datapack via UnsafeValues.loadAdvancement it should save to the "advancement" folder in the Bukkit datapack.

Observed/Actual behavior

Paper/paper-server/src/main/java/org/bukkit/craftbukkit/util/CraftMagicNumbers.java

Line 341 in 02ec8e9

File file = new File(CraftMagicNumbers.getBukkitDataPackFolder(), "data" + File.separator + key.getNamespace() + File.separator + "advancements" + File.separator + key.getKey() + ".json");

The line here uses "advancements" instead of "advancement"
Mojang changed this in 1.21

Also would need to be updated here:

Paper/paper-server/src/main/java/org/bukkit/craftbukkit/util/CraftMagicNumbers.java

Line 364 in 02ec8e9

File file = new File(CraftMagicNumbers.getBukkitDataPackFolder(), "data" + File.separator + key.getNamespace() + File.separator + "advancements" + File.separator + key.getKey() + ".json");

Steps/models to reproduce

I was testing this via a Skript add-on, so I don't have any reproducible java code.
But I did notice the wrong folder was created.

Plugin and Datapack List

[13:00:29 INFO]: ℹ Server Plugins (10):
[13:00:29 INFO]: Paper Plugins (5):
[13:00:29 INFO]:  - CorePlugin, SkBee, SkBriggy, SkNMS, StressTestBots
[13:00:29 INFO]: Bukkit Plugins (5):
[13:00:29 INFO]:  - BeeConomy, PermissionsEx, Skript, skript-reflect, Vault

Paper version

Paper version 26.1.2-7-main@6f4b004

Other

No response

[Lulu13022002]

Already fixed in #12553

[ShaneBeee]

oh awesome, thank you!