Skip to content

Skip migration for deleted dimensions post first migration in server - #13874

Merged
kennytv merged 2 commits into
PaperMC:mainfrom
Doc94:feature/dimension-regen-migration
Jul 26, 2026
Merged

Skip migration for deleted dimensions post first migration in server#13874
kennytv merged 2 commits into
PaperMC:mainfrom
Doc94:feature/dimension-regen-migration

Conversation

@Doc94

@Doc94 Doc94 commented May 9, 2026

Copy link
Copy Markdown
Member

Related to #13873 this PR with the help of @jpenilla try to manage the case where dimensions can be deleted of the server (post-migration to paper world structure).

Currently if you delete a dimension the server try to run a migration based in the changes what its not necesary, so we skip that logic and modify the later call to load worlds for manage to correctly regen that dimensions.

Know Issues.

  • If you delete the overworld dimension you get a crash for the missing world_gen_settings.dat (in paper that file is in the dimension directories), in vanilla you can get the same crash but need delete the file from the global data directory in the world

Closes #13873

@github-project-automation github-project-automation Bot moved this to Awaiting review in Paper PR Queue May 9, 2026
@jpenilla
jpenilla self-requested a review May 10, 2026 16:09
@Doc94
Doc94 marked this pull request as ready for review May 11, 2026 18:35
@Doc94
Doc94 requested a review from a team as a code owner May 11, 2026 18:35
@Doc94
Doc94 force-pushed the feature/dimension-regen-migration branch 2 times, most recently from bb4f046 to 86de8ec Compare June 29, 2026 14:25
@davidmayr

davidmayr commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Isn't it possible to recreate the world_gen_settings.dat, like done in createNewWorldData if the overworld dimension missing? I don't think paper should fail this gracefully here, especially if this also happens when the server fails to fully create the world the first time it starts up (like when e.g. another server is running on the same port)

See an example of where this is a problem here: https://mclo.gs/rUXPi0V (This is not using your patch for world migration, but it should come to the same conclusion)

Sure, this can be easily fixed by users, although I think it shouldn't be a too difficult fix for something that will definitely happen to more people in the future

@Doc94

Doc94 commented Jun 29, 2026

Copy link
Copy Markdown
Member Author

Isn't it possible to recreate the world_gen_settings.dat, like done in createNewWorldData if the overworld dimension missing? I don't think paper should fail this gracefully here, especially if this also happens when the server fails to fully create the world the first time it starts up (like when e.g. another server is running on the same port)

See an example of where this is a problem here: mclo.gs/rUXPi0V (This is not using your patch for world migration, but it should come to the same conclusion)

Sure, this can be easily fixed by users, although I think it shouldn't be a too difficult fix for something that will definitely happen to more people in the future

This require maybe not remove the gen file when migration its done for use when remove in vanilla (in vanilla you can force this error too but require more steps)... but this PR is for another thing, if you can open an issue related to this.

Co-authored-by: Jason Penilla <11360596+jpenilla@users.noreply.github.com>
@papermc-projects papermc-projects Bot moved this from Awaiting review to Full approval in Paper PR Queue Jul 26, 2026
@kennytv
kennytv enabled auto-merge (squash) July 26, 2026 08:08
@kennytv
kennytv merged commit 572ef8f into PaperMC:main Jul 26, 2026
3 checks passed
@github-project-automation github-project-automation Bot moved this from Full approval to Merged in Paper PR Queue Jul 26, 2026
@Doc94
Doc94 deleted the feature/dimension-regen-migration branch July 26, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

Migration alert appears even when there was nothing to migrate

3 participants