EntityEffect is outdated and incorrect and broken

[Machine-Maker]

Expected behavior

The following is a list of inconsistencies I found, only some of which are fixed in #7877.

• RABBIT_JUMP also applies to MinecartSpawners to reset the spawn delay on client (for the spin visual effect).
• HURT doesn't seem to be used anymore (was removed from vanilla in 23w06a).
• DEATH wrongly deprecated, valid for a host of things. ThrownEgg, Snowball, and LivingEntity
• Missing id: 4, used for EvokerFangs, Hoglin, IronGolem, Ravager, Warden
• WOLF_SMOKE applies to Cat, Parrot, Horse, and Wolf.
• WOLF_HEARTS applies to Cat, Parrot, Horse, and Wolf.
• (?) Missing id: 9 used for Player (stop using item)
• SHEEP_EAT is used for EatBlockGoal (Sheep), PrimedTNT
• LOVE_HEARTS applies to Allay, Animal
• ENTITY_POOF only applies to Mob not LivingEntity
• (?) Missing id: 22-id: 28. These should still exist, even if they have other methods.
• (?) Missing id: 31 used for FishingRod (reel in entity)
• THORNS_HURT doesn't exist anymore
• TOTEM_RESURRECT works on all entities, has extra effect if the entity is the player it was sent to.
• HURT_DROWN doesn't exist anymore
• HURT_EXPLOSION doesn't exist
• CAT_TAME_FAIL only applies to Ocelot not Cat
• CAT_TAME_SUCCESS only applies to Ocelot not Cat
• HURT_BERRY_BUSH doesn't exist anymore
• Missing id: 53. Applies to all entities (honey block slide)
• Missing id: 54. Applies to players (honey block jump)
• Missing id: 55. Applies to LivingEntity (swap hands)
• Missing id: 56. Applies to Wolf (stop shaking)
• Missing id: 58. Applies to Goat (start ram)
• Missing id: 59. Applies to Goat (end ram)
• Missing id: 60. Applies to LivingEntity (death poof)
• Missing id: 61. Applies to Warden
• Missing id: 62. Applies to Warden
• Missing id: 63. Applies to Sniffer (digging sound)

Observed/Actual behavior

All the above items illustrate a broken component of the EntityEffect system.

Steps/models to reproduce

N/A

Plugin and Datapack List

N/A

Paper version

N/A

Other

While a few of the above are fixed in #7877, I think a lot of them can be fixed now without the need for the BlockEvent, WorldEvent API.