Skip to content

Fix block place logic#9094

Merged
Owen1212055 merged 1 commit intoPaperMC:masterfrom
Lulu13022002:fix/blockplace
Apr 6, 2023
Merged

Fix block place logic#9094
Owen1212055 merged 1 commit intoPaperMC:masterfrom
Lulu13022002:fix/blockplace

Conversation

@Lulu13022002
Copy link
Copy Markdown
Contributor

Fix some broken block place logic:

  • The dispensed shulker will not play the place sound (due to its logic been removed)
  • The hanging sign text editor cannot be cancelled using the BlockPlaceEvent (not consistent with the other regular signs)
  • The jukebox logic hasn't been synced with the RecordItem

@Lulu13022002 Lulu13022002 requested a review from a team as a code owner April 3, 2023 17:08
@Owen1212055
Copy link
Copy Markdown
Member

Owen1212055 commented Apr 6, 2023

Snuck in some paper comment fixes (for other patches), thank you tho!

@Owen1212055 Owen1212055 merged commit 3c8c223 into PaperMC:master Apr 6, 2023
@Lulu13022002 Lulu13022002 deleted the fix/blockplace branch April 8, 2023 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants