Merged
Conversation
8597e0c to
86a26d7
Compare
Member
Author
|
So we need to decide what happens if someone registers a callback for a UUID that already has one registered, and when exactly those callbacks are fired. |
051cbfe to
8a243d1
Compare
Member
|
I dont think the others need marking, they stand fine as convenience methods for now. The callbacks should be called before bukkit events. For the same registered UUID, just override |
3e7413f to
391c2f2
Compare
Member
Author
|
Ok, removed all the TODO comments added and left comments explaining those decisions. Should be all ready. |
kennytv
approved these changes
Dec 24, 2023
391c2f2 to
2de01b3
Compare
lynxplay
pushed a commit
to lynxplay/paper
that referenced
this pull request
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.