Skip to content

Adventure 4.15#10045

Merged
kennytv merged 1 commit intomasterfrom
feature/adventure-4.15
Dec 25, 2023
Merged

Adventure 4.15#10045
kennytv merged 1 commit intomasterfrom
feature/adventure-4.15

Conversation

@Machine-Maker
Copy link
Copy Markdown
Member

@Machine-Maker Machine-Maker commented Dec 18, 2023

- [x] removeResourcePacks(UUID, UUID...)
- [x] clearResourcePacks
- [x] sendResourcePacks(ResourcePackRequest)
- [x] request callbacks
- [x] Translator#hasAnyTranslations (improve perf for rendering translatables)
- [ ] mark other send methods on Player as Obsolete/Deprecated?
- [x] bundle packet
- [x] ~~options for default serializers~~not required, old way still works
- [x] TranslationArgument migration

@Machine-Maker Machine-Maker changed the title work on updating to adventure 4.15 Adventure 4.15 Dec 18, 2023
@Machine-Maker
Copy link
Copy Markdown
Member Author

So we need to decide what happens if someone registers a callback for a UUID that already has one registered, and when exactly those callbacks are fired.

@Machine-Maker Machine-Maker force-pushed the feature/adventure-4.15 branch 5 times, most recently from 051cbfe to 8a243d1 Compare December 19, 2023 19:35
@Machine-Maker Machine-Maker marked this pull request as ready for review December 19, 2023 20:07
@Machine-Maker Machine-Maker requested a review from a team as a code owner December 19, 2023 20:07
@kennytv
Copy link
Copy Markdown
Member

kennytv commented Dec 23, 2023

I dont think the others need marking, they stand fine as convenience methods for now. The callbacks should be called before bukkit events. For the same registered UUID, just override

@Machine-Maker Machine-Maker force-pushed the feature/adventure-4.15 branch 3 times, most recently from 3e7413f to 391c2f2 Compare December 23, 2023 19:30
@Machine-Maker
Copy link
Copy Markdown
Member Author

Ok, removed all the TODO comments added and left comments explaining those decisions. Should be all ready.

@kennytv kennytv merged commit 4adca3d into master Dec 25, 2023
@kennytv kennytv deleted the feature/adventure-4.15 branch December 25, 2023 10:51
lynxplay pushed a commit to lynxplay/paper that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants