Split Position from Location type hierarchy#10061
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
MiniDigger
reviewed
Dec 20, 2023
Machine-Maker
force-pushed
the
feature/bytecode-modification
branch
from
340a97b to
77180b3
Compare
Machine-Maker
force-pushed
the
feature/position-split
branch
3 times, most recently
from
ad1dacb to
f63f5c0
Compare
Member
Author
|
So I did a bit more converting methods and as you can see the diff has grown quite a bit. I'm starting to get hesitant to do this for more than methods with Location that we add. One downside of not doing it all at once is it makes it slightly more annoying to work with the API before its all converted since its 2 different types. EDIT: decided to scale back this PR to only removing Position from the Location type hierarchy and rewriting the several methods that already take Position as a parameter. |
Machine-Maker
force-pushed
the
feature/position-split
branch
2 times, most recently
from
a607689 to
d75b6c5
Compare
Machine-Maker
force-pushed
the
feature/bytecode-modification
branch
2 times, most recently
from
b9544bf to
f545498
Compare
Machine-Maker
force-pushed
the
feature/position-split
branch
from
d75b6c5 to
b7e37d7
Compare
Machine-Maker
force-pushed
the
feature/bytecode-modification
branch
from
f545498 to
8696a8c
Compare
Machine-Maker
force-pushed
the
feature/position-split
branch
2 times, most recently
from
6549dc8 to
be4a567
Compare
Machine-Maker
force-pushed
the
feature/bytecode-modification
branch
from
8696a8c to
31f14a2
Compare
Machine-Maker
force-pushed
the
feature/position-split
branch
from
be4a567 to
06fcb36
Compare
Machine-Maker
force-pushed
the
feature/bytecode-modification
branch
from
31f14a2 to
33039cd
Compare
Machine-Maker
force-pushed
the
feature/position-split
branch
from
06fcb36 to
5d35f62
Compare
Machine-Maker
force-pushed
the
feature/bytecode-modification
branch
from
33039cd to
f10858e
Compare
Machine-Maker
force-pushed
the
feature/position-split
branch
from
5d35f62 to
aa08956
Compare
kennytv
added
the
pre-softspoon: never rebased
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is how the bytecode modification framework from #10060 is used to
replace some parameter types with Position andmake Location not implement Position anymore. The test plugin is setup to compile against current paper api and show that there are no compat breaks.