Fix CraftStructureTransformer from deleting generated entities#10122
Closed
Machine-Maker wants to merge 1 commit into
Closed
Fix CraftStructureTransformer from deleting generated entities#10122Machine-Maker wants to merge 1 commit into
Machine-Maker wants to merge 1 commit into
Conversation
CraftLimitedRegion loads and stores entities in the protochunk and doesn't parse the entities from NBT each time. This *requires* that a new one instance of CraftLimitedRegion is created each time before passing it to an api consumer and then saving/clearing it afterwards. CraftStructureTransformer was creating a single instance for an entire structure place which was causing entities to be deleted so no structures would spawn entities.
bf37016 to
78e9607
Compare
Member
Author
|
Alternative fix would be to add the entity to the list stored in CraftLimitedRegion if the entities were loaded. That way you can re-use the instances and they will stay up-to-date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CraftLimitedRegionloads and stores entities in the protochunk and doesn't parse the entities from NBT each time. This requires that a new instance ofCraftLimitedRegionis created each time before passing it to an api consumer and then saving/clearing it afterwards.CraftStructureTransformerwas creating a single instance for an entire structure place which was causing entities to be deleted so no structures would spawn entities.Demo to cause the issue. Just add this listener and teleport around to newly generated villages.