add rich message component support to configuration#10225
Conversation
Machine-Maker
left a comment
There was a problem hiding this comment.
We should probably allow the ability to pass custom MiniMessage instances for this for custom tags and whatnot.
Having an option to pass custom As a side note, this will currently throw an exception if a user uses |
Done. |
lynxplay
left a comment
There was a problem hiding this comment.
I think it would be great if we split this into
getRichMessage(path)
getRichMessage(path, defaultMini)
getComponent(path, ComponentSerialiser<T, String>, defaultStr)
that way, we also enable easy fetching for alternative formats down the line.
emilyy-dev
left a comment
There was a problem hiding this comment.
Generally looks good, my couple concerns are regarding documentation mostly
|
General "lets wait and see" for PaperMC/adventure#1034, as we could use ComponentDecoder over ComponentSerialiser if possible. I'd give it a couple days, otherwise we'll commodore it down the line. |
|
Also maybe the patch could/should be promoted to the adventure patch, would like to know if anyone has strong opinions against that |
Waiting another week or month will not kill it. So just wait for the decoder. |
Machine-Maker
left a comment
There was a problem hiding this comment.
Should we add set methods as well? I don't think there are for other specific types, but since we aren't hooking Component into the snakeyaml type system, maybe some set methods would be good?
Addressed with 72031ae |
|
Should we fixup this onto the adventure commit? |
|
Yea 👍 add yourself as coauthor but yea |
Done. |
resolves #5449
TODOS: