check if itemstack is stackable first#10285
Merged
Machine-Maker merged 1 commit intoMar 3, 2024
Merged
Conversation
electronicboy
approved these changes
Feb 25, 2024
Member
electronicboy
left a comment
electronicboy
left a comment
There was a problem hiding this comment.
I believe that there is already a semi-related patch which does something similar elsewhere that this could be merged in-to as said
This patch only partially fixes the problem, because the server will be overloaded with sending notifications that will show up as broadcastChanges() in spark.lucko.me. |
Member
|
sending/dealing with a lot of nested data is always going to suck, theres not too much that can be done about that unless you have full control over stuff |
granny
added a commit
to PurpurMC/Purpur
that referenced
this pull request
Feb 27, 2024
github-actions Bot
pushed a commit
to PurpurMC/Tentacles
that referenced
this pull request
Feb 27, 2024
Upstream has released updates that appear to apply and compile correctly Purpur Changes: PurpurMC/Purpur@d80fbed port PaperMC/Paper#10285
github-actions Bot
pushed a commit
to RealTriassic/LinearPaper
that referenced
this pull request
Feb 28, 2024
Upstream has released updates that appear to apply and compile correctly Purpur Changes: PurpurMC/Purpur@d80fbed port PaperMC/Paper#10285
b0ykoe
pushed a commit
to InfernalSuite/AdvancedSlimePurpur
that referenced
this pull request
Mar 2, 2024
b0ykoe
pushed a commit
to InfernalSuite/AdvancedSlimePurpur
that referenced
this pull request
Mar 2, 2024
AlwaysUpToDate
pushed a commit
to PlazmaMC/PlazmaBukkit
that referenced
this pull request
Mar 3, 2024
Upstream has released updates that appear to apply and compile correctly [Purpur Changes]PurpurMC/Purpur@d80fbed: port PaperMC/Paper#10285 [Paper Changes]PaperMC/Paper@850b736: Close PRs opened from orgs or bot accounts (#10281)
Owen1212055
approved these changes
Mar 3, 2024
Machine-Maker
approved these changes
Mar 3, 2024
SoSeDiK
added a commit
to SoSeDiKs-Universe/Kiterino
that referenced
this pull request
Mar 13, 2024
Upstream has released updates that appear to apply and compile correctly Purpur Changes: PurpurMC/Purpur@ec60d48 load config early for registerMinecraftDebugCommands option PurpurMC/Purpur@9cd8eb4 move code back into tick method, closes #1493 PurpurMC/Purpur@8f4b0ae Updated Upstream (Paper) PurpurMC/Purpur@1083e45 Updated Upstream (Paper) PurpurMC/Purpur@d80fbed port PaperMC/Paper#10285 PurpurMC/Purpur@642956f Updated Upstream (Paper) PurpurMC/Purpur@7e34461 Updated Upstream (Paper) PurpurMC/Purpur@987f46f Update remapper version PurpurMC/Purpur@65150b4 Updated Upstream (Paper)
LeonTG
pushed a commit
to LeonTG/Paper
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids an issue where unstackable items are checked against themselves when an inventory is full of items.
For more context to paper devs who are in the purpur discord: https://discord.com/channels/685683385313919172/697248751575761057/1211147576213119006
This can and should be merged into a pre-existing patch - I'm not sure which one so I've left it as it's own for now.