Adjust large packet handler to run when above protocol limit#10448
Closed
Spottedleaf wants to merge 2 commits into
Closed
Adjust large packet handler to run when above protocol limit#10448Spottedleaf wants to merge 2 commits into
Spottedleaf wants to merge 2 commits into
Conversation
Previously, PacketEncoder assumed that a packet value larger than the protocol limit would be compressed to become smaller than the protocol limit. However, not all packets will compress below the protocol limit. To try to better handle this, we will run the large packet handler when the packet size is above the protocol limit when the packet has a large packet fallback to avoid a case where the packet does not compress below protocol limit (at which point, it is too late to run the large packet handler).
kennytv
approved these changes
Apr 23, 2024
electronicboy
approved these changes
Apr 23, 2024
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, PacketEncoder assumed that a packet value larger
than the protocol limit would be compressed to become smaller
than the protocol limit. However, not all packets will compress
below the protocol limit.
To try to better handle this, we will run the large packet handler
when the packet size is above the protocol limit when the packet
has a large packet fallback to avoid a case where the packet
does not compress below protocol limit (at which point, it is
too late to run the large packet handler).