Add Event to control who hears the dragon death sound#10918
Closed
Lurkrul wants to merge 2 commits into
Closed
Conversation
yannicklamprecht
suggested changes
Jun 19, 2024
Author
|
The requested changes have been made. |
Contributor
|
Potential expansion to GlobalSoundEvent to include wither spawn sound and end portal open sound? |
Machine-Maker
requested changes
Aug 28, 2024
Member
Machine-Maker
left a comment
Machine-Maker
left a comment
There was a problem hiding this comment.
This event should probably be "generalized" a bit. I think a more general event is probably better. You won't get the "dragon" context, but smth that fires for each player that receives a level event packet of any type might be useful. We have a type that represents level events (Effect). I'm not sure if that event would fire too often though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows plugins to add/remove players from who will hear the dragon death sound.
While this has a niche use case, it will be helpful in those cases.
Servers that have their own customized enderdragon can use the event to change it to where all damage dealers will hear the noise.
This can also be used in the case where a server wants to allow players to ignore the dragon death sound.