Hide JavaPlugin commands from datapack macros#10997
Closed
Machine-Maker wants to merge 1 commit into
Closed
Conversation
Machine-Maker
added
the
publish-pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10994
Creates a second CommandDispatcher that contains all vanilla commands (and namespaced versions) as well as commands registered during bootstrap. One potential issue with this is... that you can't use the internal dispatcher provided to register commands for datapack functions. Not sure if that's resolveable and if we do want to resolve it, might have to take a different, more invasive, approach.
Download the paperclip jar for this pull request: paper-10997.zip