Fix inventory desync when placing blocks with spawn protection#11090
Merged
Conversation
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
do you have anything of value to add to this pr or are you just here to troll? |
Machine-Maker
approved these changes
Aug 28, 2024
Member
Machine-Maker
left a comment
Machine-Maker
left a comment
There was a problem hiding this comment.
Throw MC-99075 into the comment, it looks like this is a reported vanilla issue.
notTamion
force-pushed
the
fix-spawn-inv-desync
branch
from
fc7091e to
4b26546
Compare
Contributor
|
Changed with the following line of thought: Cancelling the inventory open event is less restrictive than cancelling the entire interaction all together. |
Machine-Maker
force-pushed
the
fix-spawn-inv-desync
branch
from
4b26546 to
8a6f408
Compare
lynxplay
approved these changes
Aug 31, 2024
LeonTG
pushed a commit
to LeonTG/Paper
that referenced
this pull request
May 17, 2026
…MC#11090) * fix * mention mojira issue * move to vanilla bug fixes patch --------- Co-authored-by: Jake Potrebic <jake.m.potrebic@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11012
Should we maybe call BlockPlaceEvent in a cancelled state when a player tries placing blocks with spawn protection on? This could allow plugins to pick which blocks should be placeable at spawn.