Add API for explosions to damage the explosion cause#11177
Closed
sh-dima wants to merge 8 commits into
Closed
Conversation
…h to 0484-Add-the-ability-for-explosions-to-damage-the-explosi.patch Increment patch number
|
Please do not open pull requests from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to add an API feature which expands the functionality of
World#createExplosionby adding the option to deal damage to the source entity (this is not the default behaviour). This deals with this issue (not technically a bug, but still something that I think should be addressed).The API is expanded by overloading existing
World#createExplosionmethods with a newboolean shouldDamageSourceparameter. Whentrue, the entity specified as thesourcewill be damaged by the explosion. Existing behaviour is not changed.