chore: fix incorrect commit hash in PR builds#11198
Merged
Merged
Conversation
kennytv
approved these changes
Aug 5, 2024
LeonTG
pushed a commit
to LeonTG/Paper
that referenced
this pull request
May 17, 2026
* fix incorrect hash in PR builds * only apply ref on pull_request triggers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the build workflow runs on the
pull_requesttrigger, the commit ref ends up being the merge commit generated for the pull request instead of the actual commit in a PR. This PR fixes that by setting the checkout ref to be the most recent commit pushed in the PR.Since this workflow also includes the
pushtrigger, a conditional step was added to apply the ref only if it's being run under thepull_requesttrigger.docs: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request
references: actions/checkout#261 https://github.com/actions/checkout#Checkout-pull-request-HEAD-commit-instead-of-merge-commit linz/geostore#2246