Fix LivingEntity#damageItemStack javadocs#11233
Closed
masmc05 wants to merge 1 commit into
Closed
Conversation
Member
|
I re-opened #11214 cause I think that enchants actually should be taken into account. So probably don't need this anymore. |
Contributor
Author
Glad to hear that the old useful behavior will be back. closing then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11063 introduced behaviour changes that contradicts the javadocs, confirmed in #11214 (comment) as intended changes. This pr fixes the javadocs to reflect the current behaviour.