verify returned suggestion type#11299
Closed
456dev wants to merge 2 commits into
Closed
Conversation
since generic types get erased at runtime, java doesn't actually know what is in the returned. List convert it to a String array, which only accepts the one type, which throws the ArrayStoreException when failed. additionally, since this occurs in BukkitCommandNode, the plugin/commands class is not in the stacktrace.
electronicboy
added
the
publish-pr
dawon
reviewed
Aug 19, 2024
Co-authored-by: dawon <7982418+dawon@users.noreply.github.com>
Member
|
I think this falls into a similar category as the other PR you opened relating to generic type checks at runtime. |
Contributor
Author
|
Yeah understandable. This was mainly so I could give extra debug logging build without sending a random jar. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft: need to figure out where else in the api is/isnt typesafe for lists.
since generic types get erased at runtime, java doesn't actually know what is in the returned.
here i convert it to a String array,
which only accepts the one type, which throws the ArrayStoreException when failed.
additionally, since this occurs in BukkitCommandNode, the plugin/commands class is not in the stacktrace, so i add the command class to the error log.
made to help diagnose what plugin was causing this
Download the paperclip jar for this pull request: paper-11299.zip