Fix setDamage being ran on compasses#11317
Merged
Merged
Conversation
Member
|
Is there a vanilla bug report on this? |
Machine-Maker
requested changes
Aug 23, 2024
Member
There was a problem hiding this comment.
Changing it here doesn't do anything. You are just changing it for the data generator. You have to actually change the vanilla loot table.
Vanilla issue: https://bugs.mojang.com/browse/MC-266489
lynxplay
approved these changes
Aug 25, 2024
Machine-Maker
approved these changes
Aug 25, 2024
Member
|
do we add the vanilla issue to the patch description and the paper comment? |
LeonTG
pushed a commit
to LeonTG/Paper
that referenced
this pull request
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In VanillaChestLoot, compasses accidentally have a setdamage loot function on them, but compasses don't take durability, resulting in a warning
"Couldn't set damage of loot item 1 minecraft:compass"
This patch simply removes attempting to add damage to compass