Don't save entities when a chunk's save is cancelled#11336
Closed
NewwindServer wants to merge 1 commit into
Closed
Don't save entities when a chunk's save is cancelled#11336NewwindServer wants to merge 1 commit into
NewwindServer wants to merge 1 commit into
Conversation
lynxplay
requested changes
Sep 6, 2024
Contributor
lynxplay
left a comment
lynxplay
left a comment
There was a problem hiding this comment.
Mojang disconnected chunk and entity saving a while ago.
Hence why spigot introduced the EntitiesUnloadEvent.
The fact that they save in the same logic again is entire an implementation detail of the chunk rewrite. Having the chunk event be responsible for disabling the entity saving hence becomes rough if this impl ever changes.
I think it would be better to have such a setting on the respective EntitiesUnloadEvent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From searching code across GitHub, the primary use case for ChunkUnloadEvent.setSaveChunk(false) seems to be preventing certain worlds, like minigame worlds, from being saved.
In most cases, if you're not saving a chunk, it also makes sense not to save the entities within that chunk.
Before version 1.17, this was the default behavior, as entities were saved within chunks.
However, in the current system, even when chunk saving is canceled, entities like shot arrows or unexploded TNT are still saved, which can cause leftover items in minigame worlds.