Skip to content

fire BlockExpEvent on grindstone use#11346

Merged
lynxplay merged 2 commits into
PaperMC:masterfrom
nathannm23:grindstone-blockexpevent
Sep 6, 2024
Merged

fire BlockExpEvent on grindstone use#11346
lynxplay merged 2 commits into
PaperMC:masterfrom
nathannm23:grindstone-blockexpevent

Conversation

@nathannm23
Copy link
Copy Markdown
Contributor

fix for the BlockExpEvent not being triggered when a grindstone is used
detailed here: #11338

@nathannm23 nathannm23 requested a review from a team as a code owner September 1, 2024 00:37
Comment thread patches/server/1056-Fire-BlockExpEvent-on-grindstone-use.patch Outdated
Comment thread patches/server/1056-Fire-BlockExpEvent-on-grindstone-use.patch Outdated
Comment thread patches/server/1056-Fire-BlockExpEvent-on-grindstone-use.patch Outdated
Comment thread patches/server/1056-Fire-BlockExpEvent-on-grindstone-use.patch Outdated
@nathannm23
Copy link
Copy Markdown
Contributor Author

I made the required changes to the patch though now it looks messy so I'm not sure if I did it correctly. I can start over if needed, sorry it's my first time here.

@notTamion
Copy link
Copy Markdown
Contributor

notTamion commented Sep 1, 2024

you were probably looking at the diff for your latest commit. look at the diff of the entire pr, that one looks fine

Copy link
Copy Markdown
Contributor

@notTamion notTamion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally i think i prefer this way of doing it over #9835 considering how we don't have to move around when the experience reward is calculated

@Machine-Maker Machine-Maker linked an issue Sep 1, 2024 that may be closed by this pull request
@lynxplay lynxplay force-pushed the grindstone-blockexpevent branch from 6aafe96 to 0cb1411 Compare September 6, 2024 19:57
@lynxplay lynxplay merged commit 953e6e9 into PaperMC:master Sep 6, 2024
LeonTG pushed a commit to LeonTG/Paper that referenced this pull request May 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

BlockExpEvent does not fire when using a grindstone

4 participants