Fix AttributeModifier#getUniqueId#11358
Closed
qixils wants to merge 1 commit into
Closed
Conversation
Returning null is a subjective fix, but the key changes are an objective fix to a completely broken method
Contributor
|
Upstream went another route in a recent commit , we just need to pull that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returning null is a subjective fix (throwing an exception in a getter is odd but I can revert if desired), but the key changes are an objective fix to a completely broken method (
minecraft:305cec29-c12a-49ba-aebc-38b2b61dcd40is not a valid UUID!)