Fixed issues with lidded not closing patch#11370
Conversation
lynxplay
left a comment
There was a problem hiding this comment.
Unless I am reading this wrong, the PlayerInteractEvent is called before the menu (and lidded state) is ever opened/changed.
Even with this (hardcoded as fuck) patch, you'd be too early to call close on the container anyway?
I tried running this for example 2 seconds later with scheduler and it still said it is not opened even when I was seeing it as opened. The issue was it just wasn't updated. |
|
I can try making it less hardcoded, but it would require making new interface, is that okay? |
|
I explained over in the issue why I think the Lidded open/close methods have a more fundamental problem with how lids work in the game. |
Hey, currently on latest version of paper, I'm having issues with actually using interface Lidded#close to actually close the container (barrel, shulkerbox or etc...), so I tried fixing it and well it works, I still have to fix some things there as it does not look open but still sends sound (which it shouldn't if it already closed), but I also wanted to hear a feedback before continuing.
Issue (maybe more detailed why): #11364
(sorry for previous invalid PR)