PlayerInventory#setItem check for slot outside of inventory#11397
Closed
strainxx wants to merge 0 commit into
Closed
PlayerInventory#setItem check for slot outside of inventory#11397strainxx wants to merge 0 commit into
strainxx wants to merge 0 commit into
Conversation
notTamion
reviewed
Sep 14, 2024
| + if (index < 0 || index > 40) { | ||
| + throw new ArrayIndexOutOfBoundsException("Index must be between 0 and 40"); | ||
| + } | ||
| + // Paper end - Validate setItem index |
Contributor
There was a problem hiding this comment.
This check should be done in CraftInventoryPlayer#setItem and not the super method. we could also modify the underlying nms method to set the item regardless of whether it is inbounds however that might confuse plugin developers as the player inventory is split into compartments and the index and size displayed in the exception will not match the slot input by the dev.
strainxx
force-pushed
the
fix-setitem-slot-check
branch
from
3adae82 to
73b2423
Compare
strainxx
force-pushed
the
fix-setitem-slot-check
branch
from
73b2423 to
4ff58c4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #11391
Now if setItem is < 0 or > 40 it will throw ArrayIndexOutOfBoundsException