Fix and enhance openInventory(InventoryView)#11455
Closed
masmc05 wants to merge 5 commits into
Closed
Conversation
Member
|
You can already create views with any title via the MenuType API. Is there a point to adding this with the MenuType API already in? |
Contributor
Author
|
For current opened view, this method goes trough the proper whole open inventory process without closing it, maintaining the most similar state to the pre open state |
Contributor
Author
|
Rebased on 1.21.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new method allows overriding the title on the menu which is being opened without the necessity to listen to InventoryOpenEvent and setting InventoryOpenEvent#titleOverride(Component)
When creating this new api discovered an issue with the current method which has a very small fix, the issue being that currently when running
You will get this error https://pastes.dev/yAFvj1yF6I
Should I instead of current behavior, pass the title override as the default value of InventoryOpenEvent#titleOverride?