Skip to content

Add player weather support to Entity#isInRain#11574

Closed
bridgelol wants to merge 2 commits into
PaperMC:masterfrom
bridgelol:feat/player-weather-riptide-support
Closed

Add player weather support to Entity#isInRain#11574
bridgelol wants to merge 2 commits into
PaperMC:masterfrom
bridgelol:feat/player-weather-riptide-support

Conversation

@bridgelol
Copy link
Copy Markdown
Contributor

@bridgelol bridgelol commented Nov 4, 2024

Fixes trident behaviour when using player weather. Currently riptide does not register serverside when using player-weather from plugins like Essentials (https://github.com/EssentialsX/Essentials/blob/f7a8f86850c9c4f9dee9b6120e6da151cbe81ed0/Essentials/src/main/java/com/earth2me/essentials/commands/Commandpweather.java#L19).

@bridgelol bridgelol requested a review from a team as a code owner November 4, 2024 12:21
@electronicboy
Copy link
Copy Markdown
Member

This does not consider if the biome that a player is standing in actually rains, etc

@bridgelol
Copy link
Copy Markdown
Contributor Author

This does not consider if the biome that a player is standing in actually rains, etc
Ah, you're right. Will push something tonight

@bridgelol bridgelol force-pushed the feat/player-weather-riptide-support branch from ed074ac to 5e603a7 Compare November 6, 2024 15:03
@bridgelol bridgelol changed the title Add player weather support to Entity#isInRain() Add player weather support to Entity#isInRain Nov 20, 2024
@lynxplay lynxplay force-pushed the feat/player-weather-riptide-support branch from 5e603a7 to 7f1707b Compare November 24, 2024 21:46
@lynxplay
Copy link
Copy Markdown
Contributor

This is a lot more involved of a PR I think.
From the current looks, the entire per-player weather seems to be "visual only".
The weather value is used for nothing but computing the packets.

This change now makes it a complete behaviour change.
The player would now be cleared of fire and well, can jump tridents.
I am unsure if this is what this method was intended for.

@Warriorrrr Warriorrrr moved this from Awaiting review to Waiting For Author in Paper PR Queue Mar 5, 2025
@kennytv kennytv added the pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch label Mar 23, 2025
@kennytv kennytv deleted the branch PaperMC:master March 23, 2025 19:16
@kennytv kennytv closed this Mar 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pre-softspoon: never rebased Pre-hardfork pull requests that were not re-opened with the new main branch pre-softspoon

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants